Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix#1687): Marking request as saved even when no changes are detected compared to filesystem #1688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rsilvr
Copy link
Contributor

@rsilvr rsilvr commented Feb 28, 2024

Description

Fix bug that prevents request from being marked as saved in the UI (hiding the orange dot) when the change made was reverted by user, making the draft identical to filesystem content.

This scenario is fully reproduced in this comment.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Closes #1687

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Draft indicator remains after saving when changes in file were reverted
3 participants